Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New changes and improvemenets #1437

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Conversation

EchoEllet
Copy link
Collaborator

@EchoEllet EchoEllet commented Oct 19, 2023

I should have made more changes before I sent this pull request but I couldn't help myself

but at least it's not a lot of changes

Improvements:

  • Delete old todo and unneeded
  • Improve performance by using const + dispose all the text editing controllers in dispose()
  • use (Attribute.margin, Attribute.alignment) in flutter_quill_extensions
  • Remove unused code
  • Using a better default value for linkRegExp for inserting the images
  • Update the TextFields to automatically send the form when press enter in the last field
  • Update the text input types of the text fields, suggestions, and more
  • Fix some MediaButton bugs and format code
  • Format and organize some of the source code, even in the tests, some of them done in dart format .
  • Fix bug #1432
  • Fix bug #1434
  • Fix bug #1435 by sending pull request to fluent_ui maintainers, in case they decided to reject the changes, then you need to make sure to:
      localizationsDelegates: const [
        DefaultCupertinoLocalizations.delegate,
        DefaultMaterialLocalizations.delegate,
        DefaultWidgetsLocalizations.delegate,
        FluentLocalizations.delegate,
      ],

when using FluentApp or any custom widget app

  • Add isMacOS() function in the platform checker file

Features:

  1. Add MediaButton for picking the images only since the video one is not ready
  2. Thanks to feature request #1431 by milindgoel I was able to add a new feature which allows customizing the text selection in quill editor which is useful for custom theme design system for custom app widget like FluentApp

@singerdmx
Copy link
Owner

Is this PR ready to merge or you need to make more changes

example/android/app/build.gradle Outdated Show resolved Hide resolved
example/android/app/build.gradle Outdated Show resolved Hide resolved
@EchoEllet
Copy link
Collaborator Author

Is this PR ready to merge or you need to make more changes

If you merge this then I will prepare for the next pull request

@singerdmx
Copy link
Owner

Ok

@singerdmx
Copy link
Owner

Can you cherry pick the other change related to toolbar in your next PR

@singerdmx singerdmx merged commit 988c41b into singerdmx:master Oct 19, 2023
1 check passed
@singerdmx
Copy link
Owner

#1438

@EchoEllet EchoEllet deleted the new-improvemenets branch November 14, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants