[c++] Hide internal dimensions #3266
Open
+225
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-dark
reviewed
Oct 31, 2024
Comment on lines
247
to
248
| std::shared_ptr<Context> ctx, | ||
| std::shared_ptr<Array> tiledb_array); |
There was a problem hiding this comment.
Looks like you can change the implementation so these are passed as const references instead of pointers without too much pain.
jp-dark
approved these changes
Oct 31, 2024
…ing an array for read unless explicity specify them
XanthosXanthopoulos
force-pushed
the
xan/hide_internal_dims
branch
from
b77de49
to
eb47db2
Compare
jp-dark
approved these changes
Nov 1, 2024
johnkerl
requested changes
Nov 4, 2024
There was a problem hiding this comment.
Please include in this PR's description some copy/paste of:
- Example use of how the user might keystroke out the
index_column_namesanddomainatcreate- Either for
SOMAGeometryDataFrame.create, and/or - For an ingestion step at the experiment level
- Either for
- What
domainmight look like when they read it back
Also:
- Please file a follow-on PR to update https://github.com/single-cell-data/TileDB-SOMA/tree/main/apis/python/notebooks
johnkerl
reviewed
Nov 4, 2024
| @@ -229,6 +229,22 @@ class ArrowAdapter { | |||
| static std::unique_ptr<ArrowSchema> arrow_schema_from_tiledb_array( | |||
| std::shared_ptr<Context> ctx, std::shared_ptr<Array> tiledb_array); | |||
|
|
|||
| /** | |||
| * @brief Create a an ArrowSchema from TileDB Dimension | |||
There was a problem hiding this comment.
Suggested change
| * @brief Create a an ArrowSchema from TileDB Dimension | |
| * @brief Create an ArrowSchema from TileDB Dimension |
| const Dimension& dimension); | ||
|
|
||
| /** | ||
| * @brief Create a an ArrowSchema from TileDB Attribute |
There was a problem hiding this comment.
Suggested change
| * @brief Create a an ArrowSchema from TileDB Attribute | |
| * @brief Create an ArrowSchema from TileDB Attribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Geometry dataframe creates some extra internal dimensions to support spatial indexing. When returning back the index column names and arrow schema these dimensions (being implementation-specific) should be hidden and replaces with
soma_geometryas index column.Additionally setting a range for spatial axes should only need the axis name and not the internal index names.