Google Cloud Platform - check if import map exist and create if it does not #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldenning
reviewed
May 13, 2021
| exports.readManifest = async function (filePath) { | ||
| const { bucketName, fileName } = parseFilePath(filePath); | ||
| const file = await storage.bucket(bucketName).file(fileName); | ||
| const exists = first(await file.exists()); |
There was a problem hiding this comment.
Pretty weird that file.exists() returns [true] or [false] - i was initially curious why first() was needed but then found the following links and it makes sense:
https://googleapis.dev/nodejs/storage/latest/global.html#FileExistsResponse
https://googleapis.dev/nodejs/storage/latest/File.html#exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #98
Tested that, initially, if you do not have an import map in your bucket the server breaks.
After adding the changes, the server run fine, import map is created and additional runs do not reset the import map.