URL Updates and Google Warning #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @cksammons7! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
opt12
reviewed
Jul 23, 2020
| @@ -9,7 +9,7 @@ | |||
| import cesiumpy.util.common as com | |||
|
|
|||
| # ToDo: want different geocoders? | |||
| _GEOCODER = GoogleV3() | |||
| _GEOCODER = GeocodeFarm() | |||
There was a problem hiding this comment.
This gives me a
NameError: name 'GeocodeFarm' is not defined
Add the import to the beginning (line 7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've been wanting to use the cesiumpy package, but have had problems similar to the 'Issues'. Following the cesiumjs tutorial, I made some changes to the cesiumpy code and after these changes, the package now successfully works. As mentioned in the git commits, I updated the URLs, the divid, and the geocoder.
When I ran the package the first time, there would be a Google warning. So I changed the geocoder to one that did not require a Key API for the map. I thought this would fix the issue, but still nothing would happen after running the code. I then looked at the html cesiumpy produces, and noticed differences compared to the html from the cesiumjs tutorial. So I made additional changes to match the html code.
I'm new to GitHub and coding, so I wasn't sure what to include in this but hopefully it covers what I updated. Any pointers for the future would be greatly appreciated.
Thank you!