feat: add legacyRoutes option #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `legacyRoutes` option, defaulted to `true`.
When `legacyRoutes` is true, the `?` character will automatically be
escaped:
```ts
server.respondWith('GET', '/hello?world', handler);
```
When it is false (future default), `?` has a special meaning in that it
denotes which parameters in a path are optional. Due to this, it will
not be escaped automatically:
```ts
server.respondWith('GET', '/hello\\?world', handler);
// so we can have optional params
server.respondWith('GET', '/hello/:param?', handler);
```
|
Perfect. Thank you.
I don't see how, but this is fine as is. |
|
This might change things: #226 |
fatso83
added a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
legacyRoutesoption, defaulted totrue.When
legacyRoutesis true, the?character will automatically be escaped:When it is false (future default),
?has a special meaning in that it denotes which parameters in a path are optional. Due to this, it will not be escaped automatically:something like this @fatso83 maybe
though i do wonder if we could do some smarts here and auto-escape all
?except those following a param 🤔