Merge pull request #1516 from fatso83/1512-sandbox-stub-props-on-prot…

…otype Fix for 1512: sandbox.stub() fails on prototype props
sinonjs · Aug 7, 2017 · 75ad693 · 75ad693
2 parents ec74e94 + b4a3f42
commit 75ad693
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/sinon/collection.js b/lib/sinon/collection.js
@@ -86,7 +86,8 @@ var collection = {
     },
 
     stub: function stub(object, property) {
-        if (object && typeof property !== "undefined" && !Object.prototype.hasOwnProperty.call(object, property)) {
+        if (object && typeof property !== "undefined"
+            && !(property in object)) {
             throw new TypeError("Cannot stub non-existent own property " + valueToString(property));
         }
 

diff --git a/test/issues/issues-test.js b/test/issues/issues-test.js
@@ -320,4 +320,25 @@ describe("issues", function () {
             assert.equals(this.stub.withArgs("arg").lastCall.returnValue, "return value");
         });
     });
+
+    describe("#1512", function () {
+        var sandbox;
+
+        beforeEach(function () {
+            sandbox = sinon.sandbox.create();
+        });
+
+        afterEach(function () {
+            sandbox.restore();
+        });
+
+        it("can stub methods on the prototype", function () {
+            var proto = { someFunction: function () {} };
+            var instance = Object.create(proto);
+
+            var stub = sandbox.stub(instance, "someFunction");
+            instance.someFunction();
+            assert(stub.called);
+        });
+    });
 });