Fix set iterableToString test on IE11

sinonjs · Jan 2, 2017 · a6d8e14 · a6d8e14
1 parent 3500d60
commit a6d8e14
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/lib/sinon/typeOf.js b/lib/sinon/typeOf.js
@@ -8,12 +8,8 @@
  */
 "use strict";
 
+var type = require("type-detect");
+
 module.exports = function typeOf(value) {
-    if (value === null) {
-        return "null";
-    } else if (value === undefined) {
-        return "undefined";
-    }
-    var string = Object.prototype.toString.call(value);
-    return string.substring(8, string.length - 1).toLowerCase();
+    return type(value).toLowerCase();
 };
diff --git a/package.json b/package.json
@@ -38,7 +38,8 @@
     "native-promise-only": "^0.8.1",
     "path-to-regexp": "^1.7.0",
     "samsam": "^1.1.3",
-    "text-encoding": "0.6.2"
+    "text-encoding": "0.6.2",
+    "type-detect": "^4.0.0"
   },
   "devDependencies": {
     "browserify": "^13.0.0",

diff --git a/test/util/core/iterable-to-string-test.js b/test/util/core/iterable-to-string-test.js
@@ -32,7 +32,13 @@ describe("util/core/iterable-to-string", function () {
 
     if (typeof Set === "function") {
         it("returns an String representation of Set objects", function () {
-            var set = new Set([1, "one", true, undefined, null]);
+            var set = new Set();
+            set.add(1);
+            set.add("one");
+            set.add(true);
+            set.add(undefined);
+            set.add(null);
+
             var expected = "1,'one',true,undefined,null";
 
             assert.equals(iterableToString(set), expected);