addBehavior #1302
Merged
addBehavior #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation forced behaviors to do things to `this`, which is terrible API design (`this` being a dynamic/unstable implicit argument). This commit passes the fake as the first explicit argument to behaviors instead, allowing for a clean contract.
fatso83
approved these changes
Feb 26, 2017
|
Awesome work, mate! 👍 |
This was referenced Mar 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Add a proper way to feed in custom behaviors, for people modifying
sinon.behaviorin 1.xThere's docs and a test explaining how this all works. Sinon now uses this mechanism to add its own behaviors, so I'm pretty confident this works as intended.
This PR fixes #993