Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "engines" from package.json #1608

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Remove "engines" from package.json #1608

merged 1 commit into from
Nov 3, 2017

Conversation

mroderick
Copy link
Member

As discussed in #1607, this is outdated and should be removed

@mroderick
Remove "engines" from package.json
a397cac 
As discussed in #1607, this is outdated and should be removed
mantoni
mantoni approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@mantoni mantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@mroderick mroderick merged commit 9d9c372 into master Nov 3, 2017
@mroderick mroderick deleted the mroderick-remove-engines-from-package-json branch November 3, 2017 08:34
@mroderick mroderick added the semver:patch changes will cause a new patch version label Nov 3, 2017
@mroderick
Copy link
Member Author

This has been published as sinon@4.1.1

@Rotzbua Rotzbua mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantoni mantoni mantoni approved these changes

Assignees
No one assigned
Labels
semver:patch changes will cause a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroderick @mantoni