Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(2525): ensure non empty message when error of type string is passed, but no message #2544

Merged
merged 5 commits into from
Sep 13, 2023
Merged

fix(2525): ensure non empty message when error of type string is passed, but no message #2544

merged 5 commits into from
Sep 13, 2023

Commits on Sep 11, 2023

  1. Add test case for when throwsException is passed an error of type str… 

    …ing but no message
    @peanutenthusiast
    peanutenthusiast committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2a83dfe View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Modify behavior for creating error message from error of type string … 

    …to indicate sinon created the error
    @peanutenthusiast
    peanutenthusiast committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c89e05e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Update test case to emulate potential errors

    @peanutenthusiast
    peanutenthusiast committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e677cb4 View commit details
    Browse the repository at this point in the history

  2. Apply prettier

    @peanutenthusiast
    peanutenthusiast committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    f7021ae View commit details
    Browse the repository at this point in the history

  3. Remove empty string instantiationn 

    Co-authored-by: Morgan Roderick <20321+mroderick@users.noreply.github.com>
    @peanutenthusiast @mroderick
    peanutenthusiast and mroderick authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    4267025 View commit details
    Browse the repository at this point in the history