-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-sass stops install #556
Comments
Seeing the same error trying to install on OS X El Capitan with the latest NPM from Homebrew:
|
The same here
|
As I tested here, it worked just great in node 5.4.1 and npm 3.8.6 |
+1. node v6.1.0, npm v3.8.9. Guess I'll downgrade npm for now, as per @grsabreu's comment. |
Tried with both npm v3.8.7 and v3.8.6 and got the same error. Also tried with and without node-sass pre-installed globally. Finally got it going again by going back to node 5 (v5.11.1) and npm v3.8.6. |
There are multiple issue here, all of which have been covered many times on the node-sass tracker. @dcsan npm scripts won't run lifecycle scripts as root. You need to add the
@swartzrock @grsabreu node-sass added Node 6 support in v3.7.0. The version you're using, v3.4.2, is very old and no long supported. Use that latest node-sass and you'll be fine. |
The current locked version, v3.4.2, is very old and no longer supported. It also does not support Node 6. This causing many people issues including harp users. sintaxi/harp#556
I have PR terraform, which harp uses, to update node-sass - sintaxi/terraform#130 |
So, the fix has been merged into the master branch of Terraform but no new releases of both Terraform and HarpJS have been published yet. no hard feelings.. i do like what you are doing and love HarpJS but i'm regretting i still haven't downgraded my NodeJS. I simply didn't do that because i didn't expect the fix to take this long. Thanks in advance |
Ok I tagged and released Terraform v1.1.0 but Im getting failing tests when its merged into harp. Can any one take a look for me? I have things in branch https://github.com/sintaxi/harp/tree/v0.21.0-pre |
Ok, thanks for the quick actions. I'll try and take a look asap. On Thu, May 19, 2016, 1:22 PM Brock Whitten notifications@github.com
|
@sintaxi is there a travis ci build I can see the failure on? |
@sintaxi — I have v0.21.0-pre running locally and tests (
What errors are you seeing? I don't see any Travis integration so I'm assuming you run tests locally. Thanks! |
It looks like a lot has change between terraform v0.13.2 and v1.1.0. The node-sass change may be unrelated to the failures you're seeing. |
its node-sass 467 that has been open years causing this, current unable to install, is there a way to use sass from rubygems to get around the node-sass issues sass/node-sass#467 `npm ERR! Linux 4.4.9-300.fc23.x86_64 npm ERR! node-sass@3.4.2 postinstall: |
I can get a compile if I use 4.4.5 only at the moment |
Having this same issue. npm v3.9.3 and node v6.2.1 (and node-sass 3.7.0) with zsh. Recently updated node but everything was fine before. I could install and update packages so I figured it must be Harp. Came looking and found this. I was really looking forward to trying/using Harp. Hoping for a fix soon. Edited. |
Have the same problem on npm v3.9.3 and node v6.2.1 on a fresh os installation. In my case the error seems to come from the fact that the release of node-sass is not found on github:
The url used does not point to any release in the node-sass git repo. |
You need at least node-sass@3.7.0 for Node 6 support.
|
Yes I read that before. I updated node-sass before I tried to install Harp. Still the same issue. |
Skip to the end of this comment if it's too long for you. @sintaxi I just ran tests for the branch you pushed, v0.21.0-pre. I hope I didn't go overboard here.
It's true, I am running an old OSX, so maybe you should ignore me. PS Thank you all for harp, I ❤️ it :) PPS Another bug I just had, when ran this branch (despite the tests failing):
So there must be something else going on here, not sure what it is yet. This error may stem from nodejs/node#5348, because harp hasn't been run on node 6 very much, it's possible some module is passing in an empty string somewhere. Maybe. Update: looks like the error is in stylus, found it by running
Fixed the error by adding this to stylus (diff is against https://github.com/stylus/stylus/blob/0.53.0/bin/stylus#L692, which is what this branch uses): diff --git 1/./node_modules/harp/node_modules/stylus/bin/stylus 2/stylus.js
old mode 100755
new mode 100644
index d3b946b..aa05383
--- 1/./node_modules/harp/node_modules/stylus/bin/stylus
+++ 2/stylus.js
@@ -689,7 +689,6 @@ function compileFile(file) {
*/
function createPath(file, sourceMap) {
- dest = dest || '.';
var out;
if (files.length === 1 && extname(dest) === '.css') {
return [dest, sourceMap ? '.map' : ''].join('');
@@ -808,4 +807,4 @@ function importFiles(style) {
imports.forEach(function(file) {
style.import(file);
});
-}
+}
\ No newline at end of file Update: it looks like this is fixed in the latest version of stylus, 0.54.5. So we will need to update terraform to use this version of stylus. TLDR; the only two updates that matter:Update: I opened a PR on terraform to fix an old version of stylus that had typeerrors caused by passing empty strings to path.resolve: sintaxi/terraform#131. I guess terraform will need a new release, and also it will need to be updated in harp's package.json. Update: it looks like the two failing tests are caused by harp compiling the .json files with variables into html files. See Update: it looks like harp's minification is also having problems. This stems from harp-minify's use of uglify-js. It seems like it is overzealous with removing global functions that aren't referenced in the same file. PPPS Wow does it suck to update software. I'm so glad I don't have anything in production that I needed to migrate to node 6. |
I really want to try harp and I use homebrew (as well as zsh). So I looked up a different version with brew and downgraded to node 5. Harp installed and everything appears to be working. Guess I'll stick with node 5 until whatever is going on has been resolved. Glad that it works at least. I may downgrade to LTS just to be safe but that's down the line. Good luck! |
Bump. This really needs to be fixed. |
someone on our team made a hackaround script to overwrite terraform. fragile but it seemed to work
|
I downgraded to node version 4.0.0 with Just that now |
Installing using node v7.0.0 and npm v4.0.0 fails when compiling node-sass.I followed dcsan's procedure and it works great.I also replaced node-sass version to the latest (3.10.1 at the time of writing) in terraform's package.json and no problems so far. |
I was looking for an SSG for another project and then had all the flashbacks of fighting of this issue... is there any resolution in sight? otherwise unfortunately cannot really use harpjs. |
Is there any way to disable sass feature since we only need the markdown feature? I mean not install node-sass dependence and start up harp server without sass support. |
I guess one option might be to have a docker image for harp you could run as a container... seems a shame that a SSG tool is "rendered" haha unusable by a CSS lib 😱 |
Another idea: make a version of terraform which only loads compilers/sass/etc for the languages that harp sees in the filesystem (meaning if you don't use sass, it won't load sass).
Idea: Maybe moving to a js version of sass will solve all these problems https://github.com/medialize/sass.js
|
@DTrejo totally Im on board with switching to that lib or just not shipping with sass built in. Do you happen to know how mature sass.js is? |
@paulirish has one commit, so... 😆 |
facing the same issue as OP on ubuntu 16.10, node 7.7.4 via nvm, latest node-sass still gets the permission denied problem. The same build works fine on Windows build agent, just not Linux |
Would love to see this resolved - its brought our marketing site deployment to a grinding halt :( - and we're not using SASS anyhow. |
Dylan, maybe you should buy some consulting from sintaxi and he'll take
care of this PR ;)
…On Mon, Apr 3, 2017 at 10:08 PM, Dylan Baskind ***@***.***> wrote:
Would love to see this resolved - its brought our marketing site
deployment to a grinding halt :( - and we're not using SASS anyhow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#556 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADbN7WWLVdxiLQY5wEKaaVg6UV0IIvwks5rsdBfgaJpZM4IJcVF>
.
|
Oh this is a shame. I ran into this right now. Hope this will be resolved :3 |
Still broke. @dcsan 's fix worked like a charm though! 🍻 Node - v9.6.1 |
It's 2019 and still no fix for this? I'm running Ubuntu 16.04, Node v10.15, npm v6.7.0. Node sass still stops my installation.
It's been bugging me for weeks now. All the solution from node-sass didn't work for me. |
Tried the solution by @dcsan , but I couldn't clone the github repos...
|
Fixed. |
have a new DO droplet and installed nvm
node 5.9.1
installer failed as follows
The text was updated successfully, but these errors were encountered: