Add demo notebook and per-primitive documentation #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahmish
reviewed
Dec 9, 2023
sigpro/sigpro_pipeline_demo.ipynb
Outdated
| @@ -0,0 +1,485 @@ | |||
| { | |||
There was a problem hiding this comment.
the demo notebook should be separated from the package. I suggest creating a folder under root tutorials and move the notebook there.
There was a problem hiding this comment.
Got it - notebook has been moved to the tutorials folder.
sigpro/sigpro_pipeline_demo.ipynb
Outdated
Comment on lines
293
to
305
| " turbine_id signal_id xvalues \\\n", | ||
| "0 T001 Sensor1_signal1 2020-01-01 00:00:00 \n", | ||
| "1 T001 Sensor1_signal1 2020-01-01 01:00:00 \n", | ||
| "2 T001 Sensor1_signal1 2020-01-01 02:00:00 \n", | ||
| "3 T001 Sensor1_signal1 2020-01-01 03:00:00 \n", | ||
| "4 T001 Sensor1_signal1 2020-01-01 04:00:00 \n", | ||
| "\n", | ||
| " yvalues sampling_frequency \n", | ||
| "0 [0.43616983763682876, -0.17662312586241055, 0.... 1000 \n", | ||
| "1 [0.8023828754411122, -0.14122063493312714, -0.... 1000 \n", | ||
| "2 [-1.3143142430046044, -1.1055740033788437, -0.... 1000 \n", | ||
| "3 [-0.45981995520032104, -0.3255426061995603, -0... 1000 \n", | ||
| "4 [-0.6380405111460377, -0.11924167777027689, 0.... 1000 " |
There was a problem hiding this comment.
based on our previous discussions, is this the new supported format where we have xvalues as a column of type list (like yvalues)? Or is it the original format?
- If it is the former, I would make
xvaluesa list just like yvalues. - If it is the latter, I would change the column name to
timestampto follow the dummy data https://raw.githubusercontent.com/sintel-dev/SigPro/master/sigpro/data/demo_timeseries.csv
There was a problem hiding this comment.
The xvalues column has been revised to be a list, just like yvalues -- should be correct now.
add markdown demo to tutorials folder
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added demo notebook and per-primitive documentation