Upgrade bazel to 2.1.0 #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celskeggs
force-pushed
the
428-build-chroot
branch
from
f5fbb0b
to
5e2d884
Compare
celskeggs
force-pushed
the
444-upgrade-bazel
branch
from
d29d63e
to
c337242
Compare
celskeggs
force-pushed
the
444-upgrade-bazel
branch
from
c337242
to
8b661d0
Compare
Running under newer versions of Bazel may require running our host scripts under Python 3. Fix hash-compute so that it works in both, not just Python 2.
Starting in bazel 0.27, the host python version is forced to python 3. Unfortunately, containerregistry (a dependency of rules_bazel) is not compatible with python 3, so we have to pin bazel back to python 2. We should fix this once containerregistry updates, so that we aren't stuck on an old version of python.
rules_docker pulls in an old version of subpar that is incompatible with bazel 0.27+. Use a newer version that is compatible.
Starting in bazel 0.27, the default python version is set to python 3. Unfortunately, containerregistry (a dependency of rules_bazel) is not compatible with python 3, so we have to patch it to default back to python 2. We should fix this once containerregistry updates.
We need to stay more current with Bazel than we have been, so that we can pull in the latest bugfixes and be compatible with more dependencies.
We want to stay as close to the current version of bazel as possible.
We want to keep bazel updated as much as possible.
The pkg_tar and pkg_deb rules available in bazel_tools are deprecated, and have been moved out to rules_pkg. Migrate to that repository.
The version of kubernetes we have is broken when using a newer version of bazel (i.e. 1.0+), because of some deprecated features (bugs?) that got removed. Pull in the patch that kubernetes 1.17 adds to fix it.
We want to keep bazel updated as much as possible.
We want bazel to stay near the current version.
We want to stay near the latest version.
We want bazel to stay near the latest version.
We want to keep bazel close to the latest version.
celskeggs
force-pushed
the
444-upgrade-bazel
branch
from
2286d19
to
0579eb4
Compare
celskeggs
force-pushed
the
444-upgrade-bazel
branch
from
5eb6d14
to
c521815
Compare
This was referenced Feb 10, 2020
Merged
cryslith
reviewed
Feb 10, 2020
celskeggs
force-pushed
the
444-upgrade-bazel
branch
from
67e3b9c
to
382fa0f
Compare
cryslith
previously approved these changes
Feb 14, 2020
Because we want to spend less time working out how to update our
upstream dependencies, add a script that can automatically determine
the latest debian ISO, and automatically make a commit to upgrade to
it.
This is as simple as the following command:
$ ./bump-debian-iso.sh auto
It includes a basic general-purpose bazel code modification tool that
should help us make these kinds of autoupdate scripts in general.
This commit was automatically created with bump-debian-iso.sh.
celskeggs
force-pushed
the
444-upgrade-bazel
branch
from
382fa0f
to
00a53fb
Compare
|
Merged per previously passed checks and review on 382fa0f before rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade us to a newer version of bazel. Fix incompatibilities along the way.
Also updates the debian-iso version and adds a helper script for that, because that got broken along the way.
Fixes #444.
Checklist: