Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 deprecation warnings #102

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

TomA-R
Copy link
Contributor

@TomA-R TomA-R commented Dec 13, 2024

What

Fixes deprecation warnings on PHP 8.4 - see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

For example:

Deprecated: PhpcsChanged\shouldIgnorePath(): Implicitly marking parameter $patternOption as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/Cli.php on line 454
Deprecated: PhpcsChanged\LintMessages::fromLintMessages(): Implicitly marking parameter $fileName as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/LintMessages.php on line 36
Deprecated: PhpcsChanged\PhpcsMessages::fromPhpcsJson(): Implicitly marking parameter $forcedFileName as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/PhpcsMessages.php on line 14
Deprecated: PhpcsChanged\PhpcsMessages::fromArrays(): Implicitly marking parameter $fileName as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/PhpcsMessages.php on line 18
Deprecated: PhpcsChanged\PhpcsMessagesHelpers::fromPhpcsJson(): Implicitly marking parameter $forcedFileName as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/PhpcsMessagesHelpers.php on line 11
Deprecated: PhpcsChanged\PhpcsMessagesHelpers::fromArrays(): Implicitly marking parameter $fileName as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/PhpcsMessagesHelpers.php on line 46
Deprecated: PhpcsChanged\UnixShell::executeCommand(): Implicitly marking parameter $return_val as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/UnixShell.php on line 97
Deprecated: PhpcsChanged\CacheManager::__construct(): Implicitly marking parameter $debug as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/PhpcsChanged/CacheManager.php on line 48
Deprecated: PhpcsChangedTests\SvnFixture::getSvnInfo(): Implicitly marking parameter $lastChangedRevision as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/tests/helpers/SvnFixture.php on line 47
Deprecated: PhpcsChangedTests\TestShell::executeCommand(): Implicitly marking parameter $return_val as nullable is deprecated, the explicit nullable type must be used instead in phpcs-changed/tests/helpers/TestShell.php on line 88

Testing

sirbrillig-phpcs-changed-php84

@sirbrillig
Copy link
Owner

Oh! Great work. I knew these warnings were coming.

@sirbrillig sirbrillig merged commit 84ab035 into sirbrillig:trunk Dec 13, 2024
13 checks passed
@TomA-R TomA-R deleted the php84 branch December 13, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants