Introduce TestShell for making it easier to introduce new tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Yeah, having to mock everything for every integration test was getting pretty verbose. It was fine when there were just a couple of them but now we have a lot more things going on. This is a big improvement. I merged your other PRs, causing conflicts here, but after a rebase I think this will be a great addition. Thank you. |
david-binda
force-pushed
the
add/testsShell
branch
from
6225678 to
e9805c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the other PRs, I found it unnecessarily verbose to write an integration test.
Feels like it could be made easier and less error-prone (eg: having the class to throw an exception by default in case unknown command is run) in case the project would provide some helpers. Eg.: a TestShell class, which would do the heavy lifting, while letting the developer to only focus on registering the commands.
In the PR I'm also adding a test debug function implementation, which can be shared across the tests, again minimising the amount of code developer has to write (including the PHPCS exclusion comment).
Please, take this only as a proposal, and feel free to say "No" if you don't see the fit here :)