Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git workflow #4

Merged
merged 12 commits into from
Jun 12, 2019
Merged

Add git workflow #4

merged 12 commits into from
Jun 12, 2019

Conversation

sirbrillig
Copy link
Owner

@sirbrillig sirbrillig commented Jun 7, 2019

This adds a --git CLI shortcut and a git workflow to automatically collect the three necessary pieces of data for a git-versioned file in the same way that the --svn shortcut does for svn-versioned files.

  • Add tests
  • Add workflow
  • Add CLI command
  • Add docs
  • Handle untracked and unchanged files

Fixes #3

@sirbrillig
Copy link
Owner Author

This needs to more gracefully handle untracked (by git) files and files with no changes. Those should both have test cases.

@sirbrillig
Copy link
Owner Author

There's two skipped tests that are just not working for some reason. I'd like to get them to run. It's something to do with exception handling. I think the actual CLI works correctly.

@sirbrillig
Copy link
Owner Author

🤔 now untracked git files are not being reported at all without --debug. That's no good.

@sirbrillig
Copy link
Owner Author

Now I'd like to add svn workflow tests to match the git ones.

@sirbrillig
Copy link
Owner Author

Ok, I think this is in good shape. I'd like to clean up the commit history and do a little more real-world testing before merging.

@sirbrillig sirbrillig merged commit 30cfcaa into master Jun 12, 2019
@sirbrillig sirbrillig deleted the add-git branch June 12, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for git-versioned files
1 participant