Only run orig file PHPCS linting when the new version has lint issues #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no linting issues reported by PHPCS in the new file, there is no point in checking the orig verion, since we would not report any issues anyway. This should speed up the phpcs-changed for files w/o lint issues. props to @sirbrillig for the idea.
Do not set the `$newFilePhpcsOutput` variable in catch statement as it's not actually being used later in the code. In this commit, the value of `$newFilePhpcsMessages` variable is being calculated from `PhpcsMessages::fromPhpcsJson` method with an empty string passed in as param, since it's how it's calculated for the `$oldFilePhpcsOutput`.
sirbrillig
reviewed
Feb 3, 2022
…ew one does not contain any lint issues
…ly to new behaviour As we no longer scan orig file when there are no lint messages from new one, we should not register the `svn cat` command, but instead check that it was not called, which means that the new functionality works as expected.
|
Yep, good call! I have added a new test for git workflow, and adjusted existing one for svn workflow. I made sure the test are properly failing w/o the logic change from this PR, and are passing when the change is applied. |
|
Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no linting issues reported by PHPCS in the new file, there is no point in checking the orig verion, since we would not report any issues anyway.
This should speed up the phpcs-changed for files w/o lint issues.
props to @sirbrillig for the idea.