Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options class, take 2 #71

Merged
merged 21 commits into from
Apr 29, 2023
Merged

Add options class, take 2 #71

merged 21 commits into from
Apr 29, 2023

Conversation

sirbrillig
Copy link
Owner

@sirbrillig sirbrillig commented Apr 29, 2023 •
edited
Loading

This replaces the options array with a CliOptions class that has validation.

This is a second attempt, since #48 took too long and was too big a refactor. This time, we create the CliOptions class but then convert it back into an array to allow for easier migration.

In later PRs we can migrate other functions to accept CliOptions instead of the array.

@sirbrillig sirbrillig self-assigned this Apr 29, 2023
@sirbrillig sirbrillig mentioned this pull request Apr 29, 2023
Closed
sirbrillig added 17 commits April 29, 2023 17:29
@sirbrillig
Mention XML report mode in the README
52dba18
@sirbrillig
Add files to CliOptions->toArray
02f7a9f
@sirbrillig
Remove duplicate debug in CliOptions->toArray
8dfda0a
@sirbrillig
Use $options->files for file list in executable
42d4cbe
@sirbrillig
Convert reportMessagesAndExit to use CliOptions
0c2fc61
@sirbrillig
Add scanning of executable to static-analysis
c98b5c5
@sirbrillig
Modify github workflow to use more generic static-analysis command
49ee5c0
@sirbrillig
Make sure fileName is always set in Cli workflow commands
12706f7
@sirbrillig
Fix calls to shouldIgnorePath in executable
35405e6
@sirbrillig
Remove unnecessary early exit for missing options
374ea5e 
According to static analysis, this will never happen?
@sirbrillig
Fix call to runManualWorkflow
4bb03f5
@sirbrillig
Replace phpstan with psalm
9b81dd2
@sirbrillig
Make flattening arrays safer
107db2a
@sirbrillig
Add even more guards to shouldIgnorePath calls
8ba3cf1
@sirbrillig
Remove unnecessary uninstall command in workflow
3d18d7f
@sirbrillig
Update README to mention static-analysis command
351839b
@sirbrillig
Add psalm config and remove phpstan config
aabc014
@sirbrillig sirbrillig marked this pull request as ready for review April 29, 2023 22:38
@sirbrillig sirbrillig merged commit d7eb116 into master Apr 29, 2023
@sirbrillig sirbrillig deleted the add-options-class-2 branch April 29, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sirbrillig sirbrillig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sirbrillig