Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add executable paths to options #79

Merged
merged 13 commits into from
May 20, 2023
Merged

Add executable paths to options #79

merged 13 commits into from
May 20, 2023

Conversation

sirbrillig
Copy link
Owner

This PR adds four new options to the CLI script:

          --phpcs-path <PATH>   The path to the phpcs executable. Overrides env variables.
            --svn-path <PATH>   The path to the svn executable. Overrides env variables.
            --git-path <PATH>   The path to the git executable. Overrides env variables.
            --cat-path <PATH>   The path to the cat executable. Overrides env variables.

Partially resolves #70

sirbrillig added 6 commits May 7, 2023 16:17
@sirbrillig
Add phpcs-path option
5df0e7c
@sirbrillig
Update SvnWorkflowTest to use CliOptions
1775223
@sirbrillig
Call setOptions for SvnWorkflowTest
1c35ac9
@sirbrillig
Add getExecutablePath for git
c19a60d 
This commit could be broken up. It also does the following things:

- Move the `phpcs -i` command to ShellOperator.
- Update a few other places that use PHPCS to use getExecutablePath.
- Update runSvnWorkflow to use CliOptions.
@sirbrillig
Add svn-path and cat-path options
872b831
@sirbrillig
Add executable options to README and CLI help
763113c
@sirbrillig sirbrillig mentioned this pull request May 7, 2023
Closed
@sirbrillig sirbrillig marked this pull request as ready for review May 7, 2023 20:49
@sirbrillig sirbrillig mentioned this pull request May 7, 2023
Closed
@sirbrillig
Copy link
Owner Author

I'd like to add some tests for these new options before merge.

@sirbrillig sirbrillig merged commit 5e25928 into trunk May 20, 2023
@sirbrillig sirbrillig deleted the add-executable-paths-to-options branch May 20, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request :: Add PHPCS executable path as a parameter
1 participant
@sirbrillig