Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '--extensions' option to use in PHPCS and for allowed extensions #86

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

LetrixZ
Copy link
Contributor

@LetrixZ LetrixZ commented Jun 2, 2023

This PR adds the --extensions option to pass to PHPCS command and to use if for allowed extensions when a dir is used instead of a file.

@sirbrillig
Copy link
Owner

sirbrillig commented Jun 2, 2023

This looks very cool. Thank you for the effort! There's a few failing tests, but I think they just need the new argument provided (try composer precommit to run everything). Could you also add this option to the README?

@LetrixZ
Copy link
Contributor Author

LetrixZ commented Jun 2, 2023

Done.
Passed CliOptions instead of the single option to avoid type issues.

@juanmitriatti
Copy link

Hi @sirbrillig
This PR is really necessary and useful, will you merge it with the current beta release?.
Thanks

@sirbrillig
Copy link
Owner

That is my plan, yes. I just have had a busy weekend.

@sirbrillig
Copy link
Owner

This looks great! Thank you!

@sirbrillig sirbrillig merged commit 7027b1f into sirbrillig:trunk Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants