Fix no-vendor-phpcs flag #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP's
getoptfunction sets boolean options tofalse, which is counter-intuitive. When we parse options, we must take that into account. That was already done for other boolean options, but I made a mistake in #81 and did not correctly set the--no-vendor-phpcsoption.This was hidden because the unit tests do not use
getoptand instead create the options manually and I forgot to set the option tofalse.In this PR I fix those tests and then fix the bug.
In researching this bug, I also found a bunch of other options in the tests that did not correctly set their flags to
false, which I've also fixed (thankfully they did not uncover any additional bugs).