Do not try to validate runtime options when loading bin script #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bin script is loading, it performs certain operations which need to be run before the full
CliOptionsobjects can be safely created and validated. Notably, it needs to scan for valid filenames and, if the-ioption was provided, it needs to create a shell to ask phpcs for its installed standards.However, currently both these operations can fail because they both require creating a
CliOptionsobject when it might not be valid.This PR makes it so that the
CliOptionsobject is not validated when it would likely be invalid. Specifically, it changes the filename validation to use the raw--extensionsdata and it creates a new mode,INFO_ONLY, that can be used to safely run the-ioption.Fixes #94