Fixed typo when checking if the field diffFile is empty.
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After moving the option to `CliOptions` in commit d7eb116, the field `diff` was renamed to `diffFile`, which caused a bug in the handler for the `--diff` argument.
|
Wow, nice find. That must have totally broken manual mode. Interesting that static analysis missed that; possibly because |
Yup. That's the case. If I remove the |
sirbrillig
added a commit
that referenced
this pull request
May 23, 2024
Since `empty()` works on null undefined without a warning, it also hides bugs from static analysis (causing the bug in #99). This change should have the same effect while not ignoring warnings.
sirbrillig
added a commit
that referenced
this pull request
May 23, 2024
* Replace empty() calls in CliOptions Since `empty()` works on null undefined without a warning, it also hides bugs from static analysis (causing the bug in #99). This change should have the same effect while not ignoring warnings. * Replace `empty()` in other files with more explicit checks Again, this is because `empty()` allows undefined values and hides potential bugs from static analysis. * Replace isset with array_key_exists in Cli * Replace isset in addCacheEntry * Replace isset with array_key_exists in CliOptions->fromArray * Replace isset in CliOptions->toArray * Replace isset with array_key_exists in FullReporter * Replace isset in getPhpcsStandardOption * Use boolval to make CliOptions->toArray more explicit * Make json_encode guard more explicit in JsonReporter * Make fileName guard in LintMessages more explicit * Use more explicit guards in some UnixShell getters * Make getExecutablePath guards more explicit * Make getExecutablePath even more explicit * Add line breaks for preg_match to debug which condition is a problem psalm reports `RiskyTruthyFalsyComparison` for this line but I can't figure out why. * Replace `empty()` in UnixShell->getPhpcsVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving the options to
CliOptionsin commit d7eb116, the fielddiffwas renamed todiffFile, which caused a bug in the handler for the--diffargument.