Backport all of 3.0 to 2.x without phpcsutils #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although PHPCSUtils presents an amazing mechanism for this package to improve its compatibility and reduce false positives, as a project it remains in an alpha state and in the meantime it blocks this package from all the features added since the 2.x branch. Notably, PHP 7.4 support and improved scope detection.
This PR backports the entirety of the 3.0 branch to 2.x with the PHPCSUtils imports replaced with custom local versions that, while certainly less effective and complete than the PHPCSUtils versions, at least make the tests pass.
This would allow us to release version 2.10.0 with a lot of improvements and keep 3.0 waiting on the PHPCSUtils release cycle (which itself is waiting on PHPCS).