Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubprotocolHandler middleware #35

Merged
merged 6 commits into from
Mar 16, 2024
Merged

SubprotocolHandler middleware #35

merged 6 commits into from
Mar 16, 2024

Conversation

sirn-se
Copy link
Owner

@sirn-se sirn-se commented Jan 19, 2024

Subprotocol negotiation middleware.

Can be used on both Client and Server to help them negotiate a subprotocol to use, by evaluating lists of supported protocols provided. It does NOT implement any subprotocol, but act as a helper for negotiation.

Optionally there's a require parameter. If set, Client will throw an exception. Server will decline Handshake.

Scheduled for v2.2.

@coveralls
Copy link

coveralls commented Jan 19, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling ee5b1d8 on subprotocol-middleware
into 129db7c on v2.2-main.

Copy link

@ChristianVermeulen ChristianVermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a-ok to me! If we could just turn those echo-lines into $logger->debug() or remove then that would be perfect :-) (i don't have write access to update it)

@sirn-se sirn-se changed the base branch from v2.1-main to v2.2-main March 9, 2024 10:00
@sirn-se sirn-se changed the title [DRAFT] SubprotocolHandler prototype SubprotocolHandler middleware Mar 9, 2024
@sirn-se sirn-se merged commit c1a28ab into v2.2-main Mar 16, 2024
16 checks passed
@sirn-se sirn-se deleted the subprotocol-middleware branch March 16, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants