Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated uses of Redis#pipelined #33

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

casperisfine
Copy link
Collaborator

Context: redis/redis-rb#1059

The following is deprecated

redis.pipelined do
  redis.get(key)
end

And should be rewritten as:

redis.pipelined do |pipeline|
  pipeline.get(key)
end

Functionally it makes no difference.

Context: redis/redis-rb#1059

The following is deprecated
```ruby
redis.pipelined do
  redis.get(key)
end
```

And should be rewritten as:
```ruby
redis.pipelined do |pipeline|
  pipeline.get(key)
end
```

Functionally it makes no difference.
@sirupsen
Copy link
Owner

@casperisfine lgtm, I've made you a collaborator. What's your rubygems email?

Also full permission to move this to shopify/... it's not really used elsewhere

@casperisfine
Copy link
Collaborator Author

@casperisfine lgtm, I've made you a collaborator.

Thanks :)

What's your rubygems email?

jean[DOT]boussier[AT]gmail[DOT]com.

Also full permission to move this to shopify/... it's not really used elsewhere

That would make sense yes, this way we could publish new releases with shipit.

@sirupsen
Copy link
Owner

progressrus $ gem owner progressrus --add "<email>"
You have enabled multi-factor authentication. Please enter OTP code.
Code:   <2fa>
Adding <email>: User has already been taken

wth

@sirupsen
Copy link
Owner

image

Ah, I think something did happen

@casperisfine
Copy link
Collaborator Author

Accepted, thank you!

@casperisfine casperisfine merged commit 2d211d2 into sirupsen:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants