Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize global variables used by YAML and YAML::Syck #438

Closed
bschmalhofer opened this issue Aug 2, 2021 · 2 comments
Closed

Localize global variables used by YAML and YAML::Syck #438

bschmalhofer opened this issue Aug 2, 2021 · 2 comments
Assignees
@azumakuniyuki

Comments

@bschmalhofer
Copy link

Hi,

in https://metacpan.org/release/AKXLIX/Sisimai-v4.25.11/source/lib/Sisimai/Data/YAML.pm I noticed that the global package variables of YAML and YAML::Syck are set. The changed variables will have an effect outside of the sub dump(). I think it would be better to localize changes to these variables. This can be done by adding the local keyword in the relevant line. See also https://metacpan.org/dist/YAML/view/lib/YAML.pod#GLOBAL-OPTIONS .

Best regards,
Bernhard
@azumakuniyuki
Copy link
Member

hello, thanks for the report. I will check and test the code tomorrow :-)

@azumakuniyuki azumakuniyuki self-assigned this Aug 2, 2021
azumakuniyuki added a commit that referenced this issue Aug 2, 2021
@azumakuniyuki
#438 Add local to $YAML::* variables. Thanks to @bschmalhofer
516461d
azumakuniyuki added a commit that referenced this issue Sep 29, 2021
@azumakuniyuki
Merge pull request #439 from sisimai/issue-438-global-vars-in-data-yaml
9c0d359 
#438 Add `local` to `$YAML::*` variables. Thanks to @bschmalhofer
azumakuniyuki added a commit that referenced this issue Sep 29, 2021
@azumakuniyuki
Update the release note about issue #438 and commit 42bb08c
a010493
@azumakuniyuki
Copy link
Member

Merged into master and 4-stable.

azumakuniyuki added a commit that referenced this issue Sep 29, 2021
@azumakuniyuki
Import Pull-Request #439 reported by @bschmalhofer at #438
c3a1342
azumakuniyuki added a commit that referenced this issue Sep 29, 2021
@azumakuniyuki
Add the release note for v4.25.11p1: 250e27c and #438, #439
c50d9b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azumakuniyuki azumakuniyuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bschmalhofer @azumakuniyuki