Implement some classes in Sisimai::Rhost::* #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5-stable #523 +/- ##
============================================
+ Coverage 85.54% 85.60% +0.06%
============================================
Files 132 134 +2
Lines 6570 6599 +29
Branches 1937 1942 +5
============================================
+ Hits 5620 5649 +29
Misses 301 301
Partials 649 649 ☔ View full report in Codecov by Sentry. |
azumakuniyuki
commented
Jun 1, 2024
| # https://smtpfieldmanual.com/provider/apple | ||
| my $class = shift; | ||
| my $argvs = shift // return undef; | ||
| return $argvs->{'reason'} if $argvs->{'reason'}; |
There was a problem hiding this comment.
The code above should be removed and checked at Sisimai::Rhost->get method.
azumakuniyuki
commented
Jun 1, 2024
| # https://www.postmastery.com/yahoo-postmaster/ | ||
| my $class = shift; | ||
| my $argvs = shift // return undef; | ||
| return $argvs->{'reason'} if $argvs->{'reason'}; |
There was a problem hiding this comment.
The code above should be removed and checked at Sisimai::Rhost->get method.
azumakuniyuki
commented
Jun 1, 2024
| @@ -125,6 +125,7 @@ sub list { | |||
| Rhost/NTTDOCOMO.pm | |||
| Rhost/Spectrum.pm | |||
| Rhost/Tencent.pm | |||
| Rhost/YahooInc.pm | |||
| SMTP.pm | |||
There was a problem hiding this comment.
Rhost/Apple.pm should be added
azumakuniyuki
commented
Jun 1, 2024
| @@ -4,6 +4,7 @@ use strict; | |||
| use warnings; | |||
|
|
|||
| state $RhostClass = { | |||
| 'Apple' => ['.mail.icloud.com', '.apple.com', '.me.com'], | |||
| 'Cox' => ['cox.net'], | |||
| 'FrancePTT' => ['.laposte.net', '.orange.fr', '.wanadoo.fr'], | |||
| 'GoDaddy' => ['smtp.secureserver.net', 'mailstore1.secureserver.net'], | |||
There was a problem hiding this comment.
'GoDaddy' => ['.secureserver.net'],
azumakuniyuki
commented
Jun 1, 2024
| # @return [String] The bounce reason for Apple | ||
| # @see https://support.apple.com/en-us/102322 | ||
| # https://www.postmastery.com/icloud-postmastery-page/ | ||
| # https://smtpfieldmanual.com/provider/apple |
azumakuniyuki
added a commit
that referenced
this pull request
Jun 2, 2024
azumakuniyuki
added a commit
to sisimai/set-of-emails
that referenced
this pull request
Jun 4, 2024
azumakuniyuki
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sisimai::Reason::*intoSisimai::Rhost::*classes for each email serviceSisimai::Rhost::YahooIncfor https://senders.yahooinc.com/smtp-error-codes/set-of-emails/maildir/bsd:rhost-yahooinc-01.emlrhost-yahooinc-02.emlrhost-yaoooinc-03.emlSisimai::Rhost::Applefor iCloud Mailset-of-emails/maildir/bsd:rhost-apple-01.emlrhost-apple-02.emlrhost-apple-03.emlrhost-apple-04.eml