Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sisimai::Lhost::DragonFly #526

Merged
merged 18 commits into from
Jun 15, 2024
Merged

Sisimai::Lhost::DragonFly #526

merged 18 commits into from
Jun 15, 2024

Conversation

azumakuniyuki
Copy link
Member

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.53%. Comparing base (b853a67) to head (7f4958a).

Files Patch % Lines
lib/Sisimai/Lhost/DragonFly.pm 83.33% 2 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           5-stable     #526      +/-   ##
============================================
+ Coverage     85.51%   85.53%   +0.01%     
============================================
  Files           134      135       +1     
  Lines          6602     6650      +48     
  Branches       1937     1950      +13     
============================================
+ Hits           5646     5688      +42     
- Misses          305      307       +2     
- Partials        651      655       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

my $mbody = shift // return undef;

return undef unless index($mhead->{'subject'}, 'Mail delivery failed') > -1;
return undef unless index($mhead->{'from'}, 'MAILER-DAEMON <>') > -1;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line above may not be needed (MAILER-DAEMON)

next if length $v->{'rhost'} > 0;

my $p = [split(' ', $e, 3)];
$v->{'rhost'} ||= index($p->[0], '.') > 1 ? $p->[0] : $p->[1];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ||

# Original message follows.
$v = $dscontents->[-1];

if( index($e, 'There was an error delivering your mail to <') > -1 ) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== 0

@azumakuniyuki azumakuniyuki merged commit 3e92b18 into 5-stable Jun 15, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant