Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sisimai::Rhost->match() #529

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Conversation

azumakuniyuki
Copy link
Member

  • No longer needed Sisimai::Rhost->match
  • Other code improvement in Sisimai::Rhost and Sisimai::Fact

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.54%. Comparing base (c3fe9c9) to head (1de687b).

Files Patch % Lines
lib/Sisimai/Rhost.pm 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           5-stable     #529      +/-   ##
============================================
- Coverage     85.54%   85.54%   -0.01%     
============================================
  Files           135      135              
  Lines          6650     6640      -10     
  Branches       1950     1949       -1     
============================================
- Hits           5689     5680       -9     
  Misses          307      307              
+ Partials        654      653       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

my $remotehost = $proxy || lc $argvs->{'rhost'};
my $remotehost = lc $argvs->{'rhost'} || '';
my $domainpart = lc $argvs->{'destination'} || '';
my $rhostmatch = undef;
my $rhostclass = '';

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return undef unless length($remotehost.$domainpart);

@azumakuniyuki azumakuniyuki merged commit 422097f into 5-stable Jun 21, 2024
4 of 5 checks passed
azumakuniyuki added a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant