Prevent Regex Denial of Service in Sisimai::String.to_plain #244
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for the patch, i will merge the PR within a few days. |
gmcabrita
force-pushed
the
fix/to_plain-potential-regex-denial-of-service
branch
from
979aab8
to
51fe2e6
Compare
|
|
azumakuniyuki
added a commit
that referenced
this pull request
Nov 29, 2022
azumakuniyuki
added a commit
to sisimai/p5-sisimai
that referenced
this pull request
Nov 29, 2022
…imai::String->to_plain() #484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've hit a ReDoS in production given a email HTML body that looks somewhat like the this: https://gist.githubusercontent.com/gmcabrita/e5dc0332473fc2e3a7a407434c8d21c7/raw/00b12035e5e1b685469f143b94301a50306376ba/example.html
This is the same fix we monkeypatched in our production application.