Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Navigation bar active link stays on add bookmark #3

Closed
lsxliron opened this issue Dec 28, 2019 · 3 comments
Closed

Bug: Navigation bar active link stays on add bookmark #3

lsxliron opened this issue Dec 28, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@lsxliron
Copy link

When navigating between different pages, the navigation bar active link stays on Add Bookmark.

The navigation bar should show the current page as active

@sissbruecker
Copy link
Owner

I see that this might be confusing, but the Add bookmark button is actually just displayed more prominently because it is the most important action. So when a user looks at the header, this is the action that should stand out, compared to other pages/actions (bookmarklet, settings, logout) that are likely to be rarely used.

So I would prefer not to change this, since having the add bookmark button stand out is more important than highlighting the current page.

@lsxliron
Copy link
Author

lsxliron commented Dec 29, 2019

This is especially confusing when viewing on a mobile device.
It is possible to outline the current page menu item and keep the add bookmark untouched (you can take a look on the modified PR #5)

@sissbruecker
Copy link
Owner

sissbruecker commented Jan 12, 2020

I agree that the Add bookmark being highlighted in a drop-down menu can be confusing. However I'm still not convinced that adding an outline to the menu item for the current page is the way to go. It seems unnecessary with the other items being rarely used and there would be discrepancy with items like Logout which are an action rather than a route.

So instead I moved the Add bookmark link out of the mobile menu and changed it into a smaller link button. So now the drop-down only contains non-highlighted items and it's also easier to access the add bookmark page on mobile. Seems like a decent compromise.

Screenshot:
Bildschirmfoto 2020-01-12 um 15 55 47

@sissbruecker sissbruecker added the enhancement New feature or request label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants