Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation for LD_ENABLE_AUTH_PROXY? #372

Closed
jhauris opened this issue Nov 27, 2022 · 3 comments · Fixed by #379
Closed

Incorrect documentation for LD_ENABLE_AUTH_PROXY? #372

jhauris opened this issue Nov 27, 2022 · 3 comments · Fixed by #379
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@jhauris
Copy link
Contributor

jhauris commented Nov 27, 2022

In Options.md there is a note:

Note that this does not automatically create new users, you still need to create users as described in the README, and users need to have the same username as in the auth proxy.

But it seems the Django RemoteUser backend actually does create a user when this header is included. Is this meant to indicate that user can't access the admin panel unless separately created?

@sissbruecker
Copy link
Owner

Yeah, the assumption in the documentation is wrong. Either the documentation should be updated to state that new users are created automatically (which seems to be the default behavior of the Django authentication mechanism used here), or the application should actually prevent authentication for unknown users. I'm not really sure what is preferable.

@sissbruecker sissbruecker added documentation Improvements or additions to documentation question Further information is requested labels Dec 17, 2022
@jhauris
Copy link
Contributor Author

jhauris commented Dec 20, 2022

As someone looking to use this mechanism, I think the correct path is to create the user (and therefore update the documentation). The assumption would be whatever mechanism is creating the user is also managing user registration, so if you get to the REMOTE_USER stage, the user is valid.
If you agree, I can open a PR with the update later.

@sissbruecker
Copy link
Owner

Sounds good, I was just checking if someone had more experience with this. A PR updating the documentation would be welcome 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants