Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying port through LINKDING_PORT environment variable #156

Merged
merged 2 commits into from
Mar 26, 2022
Merged

Allow specifying port through LINKDING_PORT environment variable #156

merged 2 commits into from
Mar 26, 2022

Conversation

cschmatzler
Copy link
Contributor

While Docker containers have their own IP address namespace and port collisions are impossible to achieve, other container solutions share one.
Podman, for example, runs all containers in a pod under one namespace, which results in every port only being allowed to be assigned once. Having a default port in the image that cannot be changed can cause collisions and incompabilities.

This change allows setting a custom port for UWSGI through the environment while keeping the default port as fallback to keep backwards compatibility.

@sissbruecker
Copy link
Owner

Thanks, renamed the option to LD_SERVER_PORT to be more consistent with other options and added docs.

@sissbruecker sissbruecker merged commit c16e87f into sissbruecker:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants