Make Internet Archive integration opt-in #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new user profile setting for enabling the Internet Archive Wayback Machine integration, and disables the integration by default. As lots of users have voiced their support for this (#157), I decided to switch this to opt-in, rather than being opt-out. The feature can easily be enabled again in the settings. In order to make this change discoverable, a notification will be shown for existing users after upgrading their linkding installation, making them aware of the change in defaults. I considered introducing a setup step after the first login for new users, to make them aware of the feature, but that seemed a bit too much. Let's see first if new users have problems discovering this feature.
Closes #157