Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Wayback machine - Upgrade to 3.0.6 #281

Merged
merged 3 commits into from
Jul 3, 2022

Conversation

dustinblackman
Copy link
Contributor

@dustinblackman dustinblackman commented Jun 11, 2022

Overview

Fixes #256

The current version of waybackpy is no longer supported. This PR upgrades to the latest with the appropriate changes. A docker image is available for quick manual QA.

@dustinblackman dustinblackman marked this pull request as ready for review June 11, 2022 00:13
@dustinblackman
Copy link
Contributor Author

@sissbruecker I was getting some odd results attempting to run tests locally. Would you be able to trigger CI for this PR, please?

@dustinblackman dustinblackman changed the title Fix wayback (fix): Wayback machine 3.0.6 Jun 11, 2022
@dustinblackman dustinblackman changed the title (fix): Wayback machine 3.0.6 (fix): Wayback machine - Upgrade to 3.0.6 Jun 18, 2022
@sissbruecker
Copy link
Owner

Thanks for the version bump, the tests seem to run fine, they are just a bit noisy ATM with (expected) error messages. Added a commit to reuse the user agent from the website loader.

@sissbruecker sissbruecker merged commit b53bd9f into sissbruecker:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archiving feature doesn't work on latest docker image with Internet Archive integration enabled in settings
2 participants