Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Apple web-app meta tag #358 #359

Merged
merged 6 commits into from
May 23, 2023

Conversation

acbgbca
Copy link
Contributor

@acbgbca acbgbca commented Oct 13, 2022

Fix for #358

@vertex
Copy link

vertex commented Oct 16, 2022

👍

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I did test this on iOS, and while opening the app correctly hides the status bar, navigating to any other page of the app (add bookmark, settings, ...) adds the status bar again, and shows an option to return to the app. I would expect that there is no status bar as long as you are on a URL within the app.

@davidkarim
Copy link

Seems like a cool feature. Don't forget to merge, for the next release!

@acbgbca
Copy link
Contributor Author

acbgbca commented May 20, 2023

Looks like this won't work as I expected. I did some more reading, and for this to work the web app needs to behave like a single page web app; clicking on an action updates the content on the page rather than navigating to a new page. When you click on a link it opens it in an internal browser. Great for when you click on links (you can easily navigate back), not so good when navigating the application.

Refactoring the application to behave like a single page will likely be a significant amount of work, and probably not worth it just to satisfy this use case. I'll investigate further to see whether there is another way to get this to work.

Sorry I didn't pick this up, I rarely navigate past the homepage when using on my phone.

@sissbruecker
Copy link
Owner

Yeah, I was assuming that this only works with single page apps. linkding will probably always be server-side rendered, no plans to change that.

Note that there are several mobile apps in development (search for linkding through Github and then check repos), though I haven't tried any of them personally.

@gingerbeardman
Copy link
Contributor

gingerbeardman commented May 20, 2023

I use a WordPress installation like this, which is definitely a multi-page website, and I only see a different UI for external links. So I'm wondering if something has been missed in this PR? I'll try to take a look

@sissbruecker
Copy link
Owner

Related SO question: https://stackoverflow.com/questions/59581949/ios-safari-webapp-opens-links-in-new-window

The answer recommends adding a full PWA manifest, including a scope section.

@acbgbca
Copy link
Contributor Author

acbgbca commented May 21, 2023

Thank you for the help. I have added in a manifest file, and confirmed that the pages now show correctly.

I apologise in advance if I haven't added it using best practice. I am a Java developer, this is based on what I could find via Google. If there a is a better way let me know and I'll make the necessary changes.

bookmarks/urls.py Outdated Show resolved Hide resolved
@sissbruecker
Copy link
Owner

Thanks, did some small tweaks and added tests

@sissbruecker sissbruecker merged commit cd66dce into sissbruecker:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants