Add option to display URL below title #365
Conversation
|
I'd find this very helpful as well, thanks! |
|
Related to a staled PR #219 |
|
Thanks @sebw for the hint. I did not check the staled PRs. I will review the ToDos in detail, but from short look at it, most of the tasks are implemented as requested. I have yet to verify / implement unit tests for this PR. Hoping it to be merged soon. :) |
bookmarks/styles/bookmarks.scss
Outdated
| @@ -58,6 +58,10 @@ ul.bookmark-list { | |||
| text-overflow: ellipsis; | |||
| } | |||
|
|
|||
| .url-display { | |||
| color: $green-color; | |||
There was a problem hiding this comment.
Not happy with adding another color to the palette, the current green feels very "off". Maybe we could just lighten / darken the default link color somewhat.
From some testing:
- Light theme: rgba(87, 85, 217, 0.64)
- Dark theme: rgba(168, 177, 255, 0.73)
There was a problem hiding this comment.
Renamed variable to $secondary-link-color and added palette colors to respective scss files for dark and light themes. Waiting for other tasks before pushing changes.
bookmarks/styles/variables-dark.scss
Outdated
| $green-color: #8aaa7c; | ||
| $green-color-dark: #4a912b; |
There was a problem hiding this comment.
| $green-color: #8aaa7c; | |
| $green-color-dark: #4a912b; | |
| $secondary-link-color: #8aaa7c; |
$green-color-dark doesn't seem to be used. Since $green-color is just another variant of $link-color, maybe rename it to $secondary-link-color.
Let's also move this up to the other link color variables.
There was a problem hiding this comment.
Did changes as requested, doing other tasks before pushing changes.
| @@ -14,6 +14,11 @@ | |||
| {{ bookmark.resolved_title }} | |||
| </a> | |||
| </div> | |||
| {% if request.user.profile.display_url %} | |||
| <div class="url-path truncate"> | |||
| <span class="url-display text-sm">{{ bookmark.url }}</span> | |||
There was a problem hiding this comment.
This should use an anchor tag so you can actually click on it. Can reuse the one from the title, minus the unread / italic styles.
| @@ -60,6 +60,15 @@ <h2>Profile</h2> | |||
| Disabling this feature will hide all previously shared bookmarks from other users. | |||
| </div> | |||
| </div> | |||
| <div class="form-group"> | |||
There was a problem hiding this comment.
Let's move this up to maybe below "Bookmark date format" , so that bookmark display options are somewhat grouped together.
There was a problem hiding this comment.
Did changes as requested, doing other changes before pushing updates
package-lock.json
Outdated
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "linkding", | |||
| "version": "1.11.1", | |||
There was a problem hiding this comment.
Let's revert changes in this file. It should probably be updated, but not in this PR.
| <div class="form-group"> | ||
| <label for="{{ form.display_url.id_for_label }}" class="form-checkbox"> | ||
| {{ form.display_url }} | ||
| <i class="form-icon"></i> Display URL below title |
There was a problem hiding this comment.
| <i class="form-icon"></i> Display URL below title | |
| <i class="form-icon"></i> Show bookmark URL |
| <i class="form-icon"></i> Display URL below title | ||
| </label> | ||
| <div class="form-input-hint"> | ||
| When enabled, this setting displays the URL of the entry below the title. |
There was a problem hiding this comment.
| When enabled, this setting displays the URL of the entry below the title. | |
| When enabled, this setting displays the bookmark URL below the title. |
|
This feature looks good aside the initial design. Thanks @bah0 for working on it.🍺 |
|
Thanks for addressing the comments, I rebased and cleaned up the migrations a bit. |
sissbruecker
changed the title
Hi! Thanks for your awesome project!
I needed a feature to display the URL of bookmark below the title in bookmarks list.
I added a setting in the general page and implemented the changes necessary in the bookmark list to display it.
Feature implementation as seen in screenshot below: