Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apache reverse proxy documentation. #371

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

jhauris
Copy link
Contributor

@jhauris jhauris commented Nov 27, 2022

Also includes a docker-compose example, and minimal vhost configuration.

@sissbruecker
Copy link
Owner

Thanks for testing this! I'm not so sure about maintaining the whole Apache setup from this PR though (Dockerfile, full Apache config + Vhost config). I think it would be enough to just inline the virtual host config into the Readme details section as an example. Alternatively you could put the setup in your own repo, and we can link to that from the Readme. What do you think?

@jhauris
Copy link
Contributor Author

jhauris commented Dec 21, 2022

Thanks for testing this! I'm not so sure about maintaining the whole Apache setup from this PR though (Dockerfile, full Apache config + Vhost config). I think it would be enough to just inline the virtual host config into the Readme details section as an example. Alternatively you could put the setup in your own repo, and we can link to that from the Readme. What do you think?

That makes sense. Let me re-work this PR as you suggest:

  • add the virtual host config to the ReadMe
  • Create a tag in my repo in the branch with the docker compose setup
  • add a link in the ReadMe to the configuration in my repo

Thank you for the suggestion!

@jhauris
Copy link
Contributor Author

jhauris commented Dec 21, 2022

This PR now only includes updates to the Readme. If you don't like the link to my repo, we can just cut out the last commit.

@sissbruecker
Copy link
Owner

Looks good, thanks.

@sissbruecker sissbruecker merged commit b99d7bf into sissbruecker:master Dec 21, 2022
@jhauris jhauris deleted the apache-documentation branch December 24, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants