Trim website metadata title and description #383
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sites seem to return metadata titles / descriptions with trailing or leading whitespaces, which should be unwanted in most if not all cases. This PR adds a
.trim
method call to the fetched values, which will remove these whitespaces.The whitespaces are not shown in the bookmark list after it is saved, but they are being stored, so they are also still there when editing the bookmark.
One example would be Humble Bundle pages, e.g. this one: https://www.humblebundle.com/software/unreal-engine-ultimate-game-dev-assets-software