-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Health Check endpoint #392
Merged
sissbruecker
merged 8 commits into
sissbruecker:master
from
mckennajones:feature/health-endpoint
Jan 20, 2023
Merged
Add Health Check endpoint #392
sissbruecker
merged 8 commits into
sissbruecker:master
from
mckennajones:feature/health-endpoint
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the commits @sissbruecker 🙂. Should be closer now. I also saw this older issue #272 and PR #273 that might be able to be closed out with the addition of this endpoint. Unless there is a use-case for an endpoint that solely returns the version. |
Thanks, looks good now 👍 Thanks for the heads up, yes I think the health check endpoint should suffice for retrieving the version for now. |
This was referenced Jan 20, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple health check endpoint as mentioned in #375. The endpoint at
/health
simply returns the version of the app and a health status. It will return 'healthy` unless it is unable to connect to the DB. Could easily add other checks as deemed appropriate.Also added the health check to the Dockerfile so it will report it's health status. Example:
Btw, I'm not super familiar with django. Let me know if a middleware is not the appropriate way to add an endpoint like this.
Closes #375