Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to favicons #504

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Conversation

sissbruecker
Copy link
Owner

This adds various improvements to how favicons work:

  • Changes the default favicon provider to use a higher-resolution image to give better results for high DPI displays
  • Adds a {domain} placeholder for custom favicon providers that require only the domain / host name without the URL scheme
  • Automatically tries to detect the correct file extension for the loaded favicon
  • Adds DuckDuckGo as an alternative favicon provider to the documentation

Closes #465

@AprilNEA
Copy link

Good job, my icon service hasn't worked for a long time now.

@sissbruecker sissbruecker merged commit 5d9e487 into master Aug 15, 2023
2 checks passed
@sissbruecker sissbruecker deleted the feat/favicon-improvements branch August 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to favicons
2 participants