Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PRIVATE flag in import and export #505

Merged
merged 3 commits into from
Aug 20, 2023

Conversation

sissbruecker
Copy link
Owner

@sissbruecker sissbruecker commented Aug 20, 2023

Adds support for the PRIVATE flag when importing / exporting in the Netscape HTML format in order to improve compatibility with other bookmark apps that support marking bookmarks as public / private.

When importing bookmarks, a new option allows to import non private bookmarks (PRIVATE="0") as shared bookmarks. This is opt-in because:

  • it keeps the existing default behavior which imports all bookmarks as private
  • the export function previously did set PRIVATE="0" (=public) on all exported bookmarks, regardless whether they were shared or not

The export has been changed to properly set the PRIVATE flag, depending on whether a bookmark is marked as shared or not.

Part of #484

@sissbruecker sissbruecker merged commit 8206705 into master Aug 20, 2023
2 checks passed
@sissbruecker sissbruecker deleted the feat/map-private-flag branch August 20, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant