Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid page reload when triggering actions in bookmark list #506

Merged
merged 19 commits into from
Aug 21, 2023

Conversation

sissbruecker
Copy link
Owner

Changes the bookmark list and tag cloud to be updated in place, rather than reloading the full page, when an action like archive, delete or a bulk edit is triggered. This improves the UX:

  • The scroll position of the page doesn't reset anymore, making it easier to work with bookmarks at the end of the list
  • The bulk edit bar now stays open and keeps its state (e.g. tag names), making multiple bulk edits in a row easier

Technically this adds Javascript that cancels the form submission, posts the form programmatically, and then loads and replaces the updated HTML for the list and tag cloud. Actions that trigger navigation to a new URL (doing a search, filtering for tags, using pagination) still result in a full reload.

@sissbruecker sissbruecker merged commit be789ea into master Aug 21, 2023
2 checks passed
@sissbruecker sissbruecker deleted the feat/partials branch August 21, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant