Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Feature/122 #127

Merged
merged 14 commits into from
Apr 12, 2015
Merged

Feature/122 #127

merged 14 commits into from
Apr 12, 2015

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Apr 12, 2015

I18n example module

/**
* Returns configuration to merge with application configuration.
*
* @return array|\Traversable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we implements interfaces, I prefer to use {@inheritDoc} for this docblock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I didn't notice that, because my IDE generates the comments when implementing abstract methods.
I'm going to change it.

@samsonasik samsonasik added this to the 0.1.2 milestone Apr 12, 2015
@samsonasik
Copy link
Member

I've tested locally, and it works perfectly, I will merge in a few ;)

samsonasik added a commit that referenced this pull request Apr 12, 2015
samsonasik added a commit that referenced this pull request Apr 12, 2015
@samsonasik samsonasik merged commit 2df969a into sitrunlab:master Apr 12, 2015
samsonasik added a commit that referenced this pull request Apr 12, 2015
@samsonasik
Copy link
Member

It has been merged, and online http://learnzf2.sitrun-tech.com/learn-zf2-i18n \m/, Thank you @acelaya ;)

@samsonasik samsonasik mentioned this pull request Apr 12, 2015
@acelaya acelaya deleted the feature/122 branch April 12, 2015 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants