hotfix : restrict other "in db" modules to be download-able

[samsonasik]

currently, list module that can be downloaded comes from ApplicationConfig which should be avoided and should use in db modules instead.

[samsonasik]

is loop in factory ok ? or create new service just to collect array of moduleName ? or use loop in controller instead ?

[acelaya]

I don't see any problem

Alejandro Celaya Alastrué
http://www.alejandrocelaya.com
El 27/12/2014 03:26, "Abdul Malik Ikhsan" notifications@github.com
escribió:

In
module/Application/src/Application/Factory/Controller/DownloadControllerFactory.php
#90 (diff):

@@ -14,7 +14,13 @@ class DownloadControllerFactory implements FactoryInterface
public function createService(ServiceLocatorInterface $serviceLocator)
{
$services = $serviceLocator->getServiceLocator();

•    $moduleList = [];
  

•    foreach ($services->get('Doctrine\ORM\EntityManager')
  

•                           ->getRepository('Application\Entity\ModuleList')
  

•                           ->findAll() as $module) {
  

•        $moduleList[] = $module->getModuleName();
  

•    }
  

is loop in factory ok ? or create new service just to collect array of
moduleName ? or use loop in controller instead ?

—
Reply to this email directly or view it on GitHub
https://github.com/sitrunlab/LearnZF2/pull/90/files#r22290687.

[samsonasik]

ok, merging ;)

[samsonasik]

merged.
master : 2497d73
develop : c1550e8
changelog : c4dcfe7