Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moment-timezone is a replacement for moment, not an add-on. #37

Merged
merged 1 commit into from
Jan 20, 2017
Merged

moment-timezone is a replacement for moment, not an add-on. #37

merged 1 commit into from
Jan 20, 2017

Conversation

brandond
Copy link
Contributor

Don't require both. Doing it this way does not make any of the TZ functionality available to moment.

Fixes:

TypeError: display_timestamp.tz is not a function
    at addParsedTimestamp (logtrail.bundle.js?v=14588:1)
    at updateEventView (logtrail.bundle.js?v=14588:1)
    at logtrail.bundle.js?v=14588:1
    at processQueue (commons.bundle.js?v=14588:38)
    at commons.bundle.js?v=14588:38
    at Scope.$eval (commons.bundle.js?v=14588:39)
    at Scope.$digest (commons.bundle.js?v=14588:39)
    at Scope.$apply (commons.bundle.js?v=14588:39)
    at done (commons.bundle.js?v=14588:37)
    at completeRequest (commons.bundle.js?v=14588:37)

Don't require both. Doing it this way does not make any of the TZ functionality available to moment.

Fixes:
```
TypeError: display_timestamp.tz is not a function
    at addParsedTimestamp (logtrail.bundle.js?v=14588:1)
    at updateEventView (logtrail.bundle.js?v=14588:1)
    at logtrail.bundle.js?v=14588:1
    at processQueue (commons.bundle.js?v=14588:38)
    at commons.bundle.js?v=14588:38
    at Scope.$eval (commons.bundle.js?v=14588:39)
    at Scope.$digest (commons.bundle.js?v=14588:39)
    at Scope.$apply (commons.bundle.js?v=14588:39)
    at done (commons.bundle.js?v=14588:37)
    at completeRequest (commons.bundle.js?v=14588:37)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants