Added BIND_AS_AUTHENTICATING_USER option. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows the authentication of users with multiple unknown distinguished name (dn) formats, provided that there is at least one user whose dn is known and has the permissions to search for other users.
|
Thanks for your PR. Could you explain a little how this is different to method 2 (search and bind), except with a custom filter? |
|
It would be awesome to merge this into the code as the search and bind method (issue #2) as that has been a long-standing feature I've wanted to implement. |
|
I don't have a lot of ldap knowledge, so I'm not really sure about the differences. That is the main reason I proposed this code as a third authentication method. The only incompatible point I see at this moment is that the search step in search and bind could be anonymous (is that right?), and in my code it requires a valid password. Do you see anything else? |
Replacing references to `EntryBase.entry_get_dn()` with `EntryBase.entry_dn`, as this method does not exist anymore. Using a specific version of ldap3 from now on, as this api change caught us off guard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows the authentication of users with multiple unknown
distinguished name (dn) formats, provided that there is at least one
user whose dn is known and has the permissions to search for other
users.