Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

The ability to choose your own accent color #90

Closed
neilideal opened this issue Nov 23, 2022 · 22 comments · Fixed by #124
Closed

The ability to choose your own accent color #90

neilideal opened this issue Nov 23, 2022 · 22 comments · Fixed by #124
Labels
help wanted Extra attention is needed wontfix This will not be worked on

Comments

@neilideal
Copy link

It would be nice to add the ability for users to choose a color scheme for the application. For starters, you could make options such as blue (the original color), purple (the official service color), pink (the color of the app), and a monochrome theme

@sk22 sk22 mentioned this issue Nov 25, 2022
@sk22
Copy link
Owner

sk22 commented Nov 25, 2022

so, technically this would be a duplicate, but i just closed the other issue, so… not marking this as a duplicate :D
i like the idea – especially with the proposed options – but i won't implement this for now.
if anyone else wants to work in this, please do and submit a pull request! i think implementing this should also not be too complicated – there would need to be new styles for the respective themes and a new option in the settings. since there's already a theme picker in the settings, it should be a matter of extending the existing theming logics. the additional accent colors/themes could be a dropdown below (or above) the “true black mode” setting.

@sk22 sk22 added help wanted Extra attention is needed wontfix This will not be worked on labels Nov 25, 2022
@LucasGGamerM
Copy link

Adding a toggle for the original mastodon colors and app icon would be quite great

@neilideal
Copy link
Author

Screenshot_20221126-094610.png
This is what it looks like in Fritter. In terms of location, it does not contradict the logic that is used

@LucasGGamerM
Copy link

I managed to build megalodon using the original mastodon color scheme without any major modifications to the colors.xml file. I will be working on making it a toggle for the original mastodon color scheme and the megalodon color scheme. It would also be much appreciated if @sk22 could share the app icon project file, so that i could also change its colors based on the state of the toggle.

@LucasGGamerM
Copy link

The implementation of this is quite janky for now, and it almost doesnt work. But i have got an early alpha ready. If anyone is interested, i will post more updates on the situation here.

@LucasGGamerM
Copy link

I have scrapped my pretty bad implementation, i will instead work on supporting material you colors.

@neilideal
Copy link
Author

The implementation of this is quite janky for now, and it almost doesnt work. But i have got an early alpha ready. If anyone is interested, i will post more updates on the situation here.

It's interesting, at least to me! And I read the comment below about the idea with material you. It's even tougher!

@LucasGGamerM
Copy link

I have some good news, i managed to integrate the switch to mastodon original colors, and i am scrapping the material you color thing (too much work for what its worth). Its now implemented in a much more maintainable and clean way. I will create a pull request with the code later this afternoon. It will be awesome :D

@LucasGGamerM
Copy link

Alright guys, the code is ready and finally its bugless. I am filing the pull request.

@LucasGGamerM
Copy link

Ok, there were some bugs i didnt find, but they are all now fixed. I am waiting on the approval of the pull request.

@LucasGGamerM
Copy link

so, technically this would be a duplicate, but i just closed the other issue, so… not marking this as a duplicate :D i like the idea – especially with the proposed options – but i won't implement this for now. if anyone else wants to work in this, please do and submit a pull request! i think implementing this should also not be too complicated – there would need to be new styles for the respective themes and a new option in the settings. since there's already a theme picker in the settings, it should be a matter of extending the existing theming logics. the additional accent colors/themes could be a dropdown below (or above) the “true black mode” setting.

I will also work on implementing a greenish theme and the drop down menu for such themes. But this is not for today

@neilideal
Copy link
Author

so, technically this would be a duplicate, but i just closed the other issue, so… not marking this as a duplicate :D i like the idea – especially with the proposed options – but i won't implement this for now. if anyone else wants to work in this, please do and submit a pull request! i think implementing this should also not be too complicated – there would need to be new styles for the respective themes and a new option in the settings. since there's already a theme picker in the settings, it should be a matter of extending the existing theming logics. the additional accent colors/themes could be a dropdown below (or above) the “true black mode” setting.

I will also work on implementing a greenish theme and the drop down menu for such themes. But this is not for today

If we want to attract an audience that is leaving Twitter and looking for an app with a beautiful interface and actively developing functionality, then we can add those colors that were in Twitter itself, viz:
Blue, pink, orange, yellow, green, purple.

@LucasGGamerM
Copy link

Creating the themes themselves isnt hard. I myself did it in less than a few minutes. But implementing the ui for them is not yet feasible for me. Test week is coming, and i have to study. But besides, i will setup some time to actually put some theming options later

@sk22
Copy link
Owner

sk22 commented Nov 28, 2022

Creating the themes themselves isnt hard. I myself did it in less than a few minutes.

Tbh, I disagree. Like – themes are so easy to mess up, imo. Not only by making them, well, not pretty in the first place, but also by meeting accessibility requirements. For example, the official app, for example, has previously (after switching from blue to purple) had quite some awful contrasts – see mastodon#217 (comment).
(Contrasts can be checked with tools like https://webaim.org/resources/contrastchecker)

@LucasGGamerM
Copy link

I did not make myself clear. I meant choosing primary colors. In my pull request, I reimplemented the purpleish mastodon theme by parenting the already existing theme. Therefore, all that changed were the accent colors, which is exactly what we want.

@LucasGGamerM
Copy link

Implementing material you colors is seeming to be quite the issue. Specially because whenever I include the required libraries, the app fails to load, saying that there are many duplicate classes. This is quite not good

@LucasGGamerM
Copy link

Ok, I think I have quite the functional thing here. 4 color options, green, pink, purple and blue. And a nice coherent design that doesn't feel out of place. I think it's ready for release at this point
Screenshot_20221203-222951

@LucasGGamerM
Copy link

Imma add orange and yellow later too

@LucasGGamerM
Copy link

Ok guys, its basically finished. The fab, the publish button, the trueblack theme, everything is just set right. Hopefully @sk22 aproves the pull request. When he does so, this issue will be closed. I think that's it

@LucasGGamerM
Copy link

I found a few minor inconsistencies, imma fix them tomorrow

@sk22
Copy link
Owner

sk22 commented Dec 5, 2022

Ok guys, its basically finished. The fab, the publish button, the trueblack theme, everything is just set right. Hopefully @sk22 aproves the pull request. When he does so, this issue will be closed. I think that's it

I'll look over the code when I find time and maybe make some adjustments, but I definitely want to merge the PR soon. The screenshots look really good, thanks a lot!

@sk22 sk22 closed this as completed in #124 Dec 7, 2022
@LucasGGamerM
Copy link

Hey, so, I implemented a Material you color theme option on https://github.com/LucasGGamerM/moshidon/releases/tag/1.1.4%2Bfork.62.moshinda . Github was a little worky and didnt allow me to create a pull request. But its done and its there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants