Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Proper implementation of the color picker #124

Merged

Conversation

LucasGGamerM
Copy link

This time, following the recommendations of @sk22, I can finally say I fixed #90 with a golden key. Its now a menu instead of a switch, and its also quite simple to add new themes. I myself plan on making a green theme later :D

@LucasGGamerM
Copy link
Author

This is a preview of what it looks like right now

screen-20221202-112836.mp4

@LucasGGamerM
Copy link
Author

And now there is a green theme

@LucasGGamerM
Copy link
Author

I have made the green theme a little better. A lot better in fact. I extracted the colors from the green material you pallet on my phone, and i am quite pleased with the results :D

@LucasGGamerM
Copy link
Author

Screenshot_20221203-134713
Screenshot_20221203-134708
Look at them! They are quite gorgeous imo

@LucasGGamerM
Copy link
Author

Working on a blue theme right now :D

@LucasGGamerM
Copy link
Author

Doing some refactoring

@muznyo
Copy link

muznyo commented Dec 3, 2022

have you thought about dynamic colors option?

@LucasGGamerM
Copy link
Author

This project has some conflicting classes if I import the required libraries for dynamic colors, which means that I cant compile it right if I use the libraries responsible for dynamic colors.

@LucasGGamerM
Copy link
Author

Screenshot_20221203-222951
And now there is a beautiful little icon there :D

@LucasGGamerM
Copy link
Author

On testing I found some readability problems with the light blue theme, will look into it

@LucasGGamerM
Copy link
Author

Now working on an orange and yellow theme

@LucasGGamerM
Copy link
Author

image
Oh boy, the orange theme is FIRE

@LucasGGamerM
Copy link
Author

Time to work on a yellow theme :D

@LucasGGamerM
Copy link
Author

image
image
Now there is a beautiful yellow theme!

@LucasGGamerM
Copy link
Author

And now I shall work on getting the TrueBlack theme just right and also get the fab and post buttons to follow the color scheme

@LucasGGamerM
Copy link
Author

So all i need to do to finish this is to make it so that the publish button also follows the theme. Because as it is, its quite not great

@LucasGGamerM
Copy link
Author

So, I would say that its basically done. If you find any inconsistencies with the theme picker please share

@LucasGGamerM
Copy link
Author

Now its ready for prime time (i hope)

@LucasGGamerM
Copy link
Author

So yes, it's done. There is hardly anything that catches the eye as incoherent anymore. Hopefully this gets merged

@sk22 sk22 force-pushed the main branch 2 times, most recently from 34a2c1b to 563afd4 Compare December 7, 2022 12:50
@sk22 sk22 merged commit e274b7e into sk22:main Dec 7, 2022
@sk22
Copy link
Owner

sk22 commented Dec 7, 2022

the themes look really good, thanks a lot for all your efforts!!

@LucasGGamerM
Copy link
Author

Lovely, I ended up creating my own fork of megalodon called moshidon. In case I make any other meaningful changes I will also try to pull request them here :D

@LucasGGamerM LucasGGamerM deleted the proper_implementation_of_the_color_picker branch March 19, 2023 01:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ability to choose your own accent color
3 participants